Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(obstacle_avoidance_planner): node refactoring #1829

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Sep 9, 2022

Description

just refactoring. no behavior change.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@takayuki5168 takayuki5168 changed the title Refactor/obstacle avoidance refactor(obstacle_avoidance_planner): general refactoring Sep 9, 2022
@takayuki5168 takayuki5168 changed the title refactor(obstacle_avoidance_planner): general refactoring refactor(obstacle_avoidance_planner): node refactoring Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Base: 10.44% // Head: 10.24% // Decreases project coverage by -0.20% ⚠️

Coverage data is based on head (7fd511b) compared to base (23e261c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
- Coverage   10.44%   10.24%   -0.21%     
==========================================
  Files        1233     1237       +4     
  Lines       88027    89776    +1749     
  Branches    20501    20501              
==========================================
  Hits         9197     9197              
- Misses      69319    71068    +1749     
  Partials     9511     9511              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.43% <0.00%> (ø) Carriedforward from 23e261c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...t/include/lidar_centerpoint/centerpoint_config.hpp 0.00% <ø> (ø)
perception/lidar_centerpoint/src/node.cpp 0.00% <0.00%> (ø)
...lude/obstacle_avoidance_planner/common_structs.hpp 0.00% <ø> (ø)
...e/obstacle_avoidance_planner/costmap_generator.hpp 0.00% <ø> (ø)
...e/obstacle_avoidance_planner/eb_path_optimizer.hpp 0.00% <ø> (ø)
...clude/obstacle_avoidance_planner/mpt_optimizer.hpp 0.00% <ø> (ø)
...lanner/include/obstacle_avoidance_planner/node.hpp 0.00% <0.00%> (ø)
...include/obstacle_avoidance_planner/utils/utils.hpp 0.00% <0.00%> (ø)
...stacle_avoidance_planner/src/costmap_generator.cpp 0.00% <0.00%> (ø)
...stacle_avoidance_planner/src/eb_path_optimizer.cpp 0.00% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 marked this pull request as ready for review September 9, 2022 13:25
@kosuke55 kosuke55 self-requested a review September 12, 2022 03:34
@kosuke55 kosuke55 marked this pull request as draft September 12, 2022 03:35
@kosuke55 kosuke55 marked this pull request as ready for review September 12, 2022 03:35
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this PR, the arc path can not be kept after starting driving from stopped.

before

refactor_avoidance_pull_over-2022-09-12_12.31.29.mp4

after

refactor_avoidance_pull_over-2022-09-12_12.26.51.mp4

For generating this issue, set enable_shift_parking and enable_arc_backward_parking to false

https://github.com/autowarefoundation/autoware.universe/blob/main/planning/behavior_path_planner/config/pull_over/pull_over.param.yaml

@takayuki5168 takayuki5168 force-pushed the refactor/obstacle-avoidance branch from e11e665 to e9c13a8 Compare September 14, 2022 11:11
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the refactor/obstacle-avoidance branch from e9c13a8 to cd078f8 Compare September 15, 2022 12:48
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 merged commit 93cc9bd into autowarefoundation:main Sep 15, 2022
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ation#1829)

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ation#1829)

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ation#1829)

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ation#1829)

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* refactor

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 deleted the refactor/obstacle-avoidance branch February 9, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants