Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_ad_api_specs): define motion interface #1808

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Sep 8, 2022

Description

The interface definition for #1809, #1810.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Base: 10.33% // Head: 10.78% // Increases project coverage by +0.45% 🎉

Coverage data is based on head (18f910b) compared to base (02fb8ae).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1808      +/-   ##
==========================================
+ Coverage   10.33%   10.78%   +0.45%     
==========================================
  Files        1147     1225      +78     
  Lines       81613    81632      +19     
  Branches    19048    20228    +1180     
==========================================
+ Hits         8434     8807     +373     
+ Misses      64184    63633     -551     
- Partials     8995     9192     +197     
Flag Coverage Δ *Carryforward flag
differential 4.65% <ø> (?)
total 10.80% <ø> (+0.48%) ⬆️ Carriedforward from faf278b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
..._utils/include/grid_map_utils/polygon_iterator.hpp 50.00% <0.00%> (-25.00%) ⬇️
...or/include/planning_error_monitor/debug_marker.hpp 50.00% <0.00%> (-25.00%) ⬇️
...oware_auto_geometry/test/src/test_hull_pockets.cpp 45.65% <0.00%> (-10.60%) ⬇️
...autoware_auto_geometry/test/src/test_common_2d.cpp 42.85% <0.00%> (-10.48%) ⬇️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 73.58% <0.00%> (-9.44%) ⬇️
...ion/include/fault_injection/diagnostic_storage.hpp 53.84% <0.00%> (-7.70%) ⬇️
...lude/motion_utils/trajectory/path_with_lane_id.hpp 66.66% <0.00%> (-7.41%) ⬇️
common/motion_testing/test/trajectory_checks.cpp 20.00% <0.00%> (-7.28%) ⬇️
...oware_auto_geometry/test/src/test_intersection.cpp 40.54% <0.00%> (-6.96%) ⬇️
... and 767 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should wait for tier4/tier4_autoware_msgs#53.

@isamu-takagi isamu-takagi enabled auto-merge (squash) September 21, 2022 07:19
@isamu-takagi isamu-takagi merged commit d85da95 into autowarefoundation:main Sep 21, 2022
@isamu-takagi isamu-takagi deleted the feature/ad-api/motion-interface branch September 21, 2022 09:01
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* feat(autoware_ad_api_specs): define motion interface

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: add error code

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move adapi messages

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(component_interface_utils): apply message change

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: change message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Sep 29, 2022
…ion#1808)

* feat(autoware_ad_api_specs): define motion interface

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: add error code

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move adapi messages

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(component_interface_utils): apply message change

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: change message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(autoware_ad_api_specs): define motion interface

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: add error code

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move adapi messages

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(component_interface_utils): apply message change

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: change message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* feat(autoware_ad_api_specs): define motion interface

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: add error code

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move adapi messages

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(component_interface_utils): apply message change

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: change message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* feat(autoware_ad_api_specs): define motion interface

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: add error code

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: move adapi messages

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat(component_interface_utils): apply message change

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

* feat: change message type

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants