refactor(ndt_scan_matcher): refactor callbackSensorPoints

[kminoda]

Signed-off-by: kminoda koji.m.minoda@gmail.com

Description

• refactored callbackSensorPoints
• refactored alignUsingMonteCarlo
• modified the function name from lowerCamerCase to snake_case
• changed the definition of exe_time in callbackSensorPoints

Related links

Tests performed

Ran Autoware tutorial rosbag with logging_simulator and confirmed that the performance does not change before and after this modification.

(Performance must not change)

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Base: 10.32% // Head: 10.27% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (24b77a2) compared to base (c57206c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1757      +/-   ##
==========================================
- Coverage   10.32%   10.27%   -0.06%     
==========================================
  Files        1147     1208      +61     
  Lines       81613    87401    +5788     
  Branches    19048    20076    +1028     
==========================================
+ Hits         8429     8982     +553     
- Misses      64188    69117    +4929     
- Partials     8996     9302     +306     

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	10.29% <0.00%> (-0.02%)	⬇️	Carriedforward from 0a2bcef

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...include/ndt_scan_matcher/ndt_scan_matcher_core.hpp	0.00% <0.00%> (ø)
...can_matcher/include/ndt_scan_matcher/util_func.hpp	0.00% <ø> (ø)
localization/ndt_scan_matcher/src/debug.cpp	0.00% <0.00%> (ø)
...ion/ndt_scan_matcher/src/ndt_scan_matcher_core.cpp	0.00% <0.00%> (ø)
...n/ndt_scan_matcher/src/pose_array_interpolator.cpp	0.00% <0.00%> (ø)
localization/ndt_scan_matcher/src/util_func.cpp	0.00% <0.00%> (ø)
...polation/include/interpolation/zero_order_hold.hpp	47.05% <0.00%> (-34.76%)	⬇️
...ocity_planner/src/utilization/path_utilization.cpp	18.91% <0.00%> (-2.30%)	⬇️
...tion/include/interpolation/interpolation_utils.hpp	54.83% <0.00%> (-1.83%)	⬇️
control/trajectory_follower/test/test_mpc.cpp	55.68% <0.00%> (-1.14%)	⬇️
... and 396 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[IshitaTakeshi]

For a large change like this I think we definitely need tests but for this time I can approve

[YamatoAndo]

There are a lot of changes, but I approve this pr because the localization worked as before.