-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection): use intersection_area if available #1733
feat(intersection): use intersection_area if available #1733
Conversation
d121bce
to
f6d92ea
Compare
Codecov ReportBase: 10.35% // Head: 10.04% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1733 +/- ##
==========================================
- Coverage 10.35% 10.04% -0.31%
==========================================
Files 1146 1255 +109
Lines 81448 90514 +9066
Branches 19003 20662 +1659
==========================================
+ Hits 8433 9094 +661
- Misses 63895 72006 +8111
- Partials 9120 9414 +294
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
f6d92ea
to
801e5ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
acfcf67
to
8e19468
Compare
4fe1ec8
to
bc32f5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bc32f5b
to
6c1950e
Compare
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…f it is deviated Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…s the goal (autowarefoundation#1818)" This reverts commit 98a01c0. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…e reaches the goal (autowarefoundation#1818)"" This reverts commit e68f86b. Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
6c1950e
to
0bf3bf8
Compare
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ation#1733) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…ation#1733) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Description
If the
intersection_area
is set at the intersection and each lanelet is associated with it, use it for detection.detection_area_with_margin
as beforeintersection_area
additionallyIf area is available it will be visualized as the debug marker.
How it works
intersection_area
adjacent_lanes
, it is not detecteddetection_area
, detect thisTests performed
In the movie if the object is in
adjacent_lanes
(orange aera) it is not detected in intersection module. Otherwise it is detected if it is inintersectsion_area
(in most cases its prediction path does not collide with ego's path).intersection_area_adjacnet_lanes-2022-09-05_23.33.15.mp4
Notes
detection_area_with_margin
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.