-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(trajectory_follower, trajectory_follower_nodes): update docs #1591
docs(trajectory_follower, trajectory_follower_nodes): update docs #1591
Conversation
3baf1ec
to
660936c
Compare
e01b930
to
cf77546
Compare
Codecov Report
@@ Coverage Diff @@
## main #1591 +/- ##
=========================================
+ Coverage 9.90% 11.09% +1.18%
=========================================
Files 1195 1111 -84
Lines 77392 81370 +3978
Branches 18206 20310 +2104
=========================================
+ Hits 7669 9030 +1361
- Misses 61058 63163 +2105
- Partials 8665 9177 +512
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
33e9bda
to
39c44df
Compare
control/trajectory_follower/design/mpc_lateral_controller-design.md
Outdated
Show resolved
Hide resolved
control/trajectory_follower/design/mpc_lateral_controller-design.md
Outdated
Show resolved
Hide resolved
control/trajectory_follower/design/pid_longitudinal_controller-design.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work!
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
5cdadaf
to
4c48a75
Compare
…er4#1591) * docs(trajectory_follower, trajectory_follower_nodes): update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove auto issue link Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * correct sentences Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add example of keep stopped Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update controller class diagram Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…er4#1591) * docs(trajectory_follower, trajectory_follower_nodes): update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove auto issue link Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * correct sentences Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add example of keep stopped Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update controller class diagram Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…er4#1591) * docs(trajectory_follower, trajectory_follower_nodes): update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove auto issue link Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * correct sentences Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add example of keep stopped Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update controller class diagram Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…towarefoundation#1591) * docs(trajectory_follower, trajectory_follower_nodes): update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove auto issue link Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * correct sentences Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add example of keep stopped Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update controller class diagram Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…er4#1591) * docs(trajectory_follower, trajectory_follower_nodes): update docs Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * remove auto issue link Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * correct sentences Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * add example of keep stopped Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * update controller class diagram Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Co-authored-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…autowarefoundation#8681) (autowarefoundation#1591) Co-authored-by: TaikiYamada4 <129915538+TaikiYamada4@users.noreply.github.com>
…e_launch (autowarefoundation#8681) (autowarefoundation#1591)" This reverts commit bad0007.
Description
update docs related to #901
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.