Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(base_interface): add base_interface package #1512

Closed
wants to merge 16 commits into from

Conversation

HaoruXue
Copy link
Contributor

@HaoruXue HaoruXue commented Aug 3, 2022

Signed-off-by: Haoru Xue haoru.xue@autoware.org

Description

Adds base_interface package to Autoware.Universe

Related links

#1451

Tests performed

New tests are included in this package.

Notes for reviewers

According to the architecture design, Autoware is missing an ActuationStatus message as a feedback back to control modules, which may need further discussion on.

StationaryLockingCommand, if still needed, may be missing a corresponding StationaryLockingReport.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@HaoruXue HaoruXue self-assigned this Aug 3, 2022
@HaoruXue HaoruXue added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Aug 3, 2022
@HaoruXue HaoruXue force-pushed the vehicle_interface branch from a4d3a24 to 02b33ec Compare August 3, 2022 22:23
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Attention: Patch coverage is 37.16216% with 186 lines in your changes missing coverage. Please review.

Project coverage is 10.83%. Comparing base (b087957) to head (616231b).
Report is 6323 commits behind head on main.

Files with missing lines Patch % Lines
...ehicle/base_interface/test/test_base_interface.cpp 22.88% 36 Missing and 55 partials ⚠️
vehicle/base_interface/src/base_interface_node.cpp 43.05% 0 Missing and 41 partials ⚠️
vehicle/base_interface/test/dummy_node.cpp 52.45% 24 Missing and 5 partials ⚠️
vehicle/base_interface/src/base_interface.cpp 46.51% 16 Missing and 7 partials ⚠️
...nterface/include/base_interface/base_interface.hpp 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1512      +/-   ##
==========================================
+ Coverage   10.72%   10.83%   +0.11%     
==========================================
  Files        1115     1120       +5     
  Lines       78832    79111     +279     
  Branches    18561    18727     +166     
==========================================
+ Hits         8454     8575     +121     
- Misses      61516    61706     +190     
+ Partials     8862     8830      -32     
Flag Coverage Δ *Carryforward flag
differential 36.48% <36.48%> (?)
total 10.72% <ø> (+0.01%) ⬆️ Carriedforward from 75a45c7

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HaoruXue HaoruXue requested a review from mitsudome-r August 3, 2022 23:08
@mitsudome-r mitsudome-r requested a review from TakaHoribe August 4, 2022 00:38
@xmfcx xmfcx requested review from brkay54 and Sharrrrk August 9, 2022 16:34
@HaoruXue HaoruXue mentioned this pull request Aug 9, 2022
7 tasks
Haoru Xue and others added 14 commits August 9, 2022 21:09
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
…interface

Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
@HaoruXue HaoruXue changed the title feat(vehicle_interface): add vehicle_interface package feat(base_interface): add base_interface package Aug 10, 2022
@HaoruXue
Copy link
Contributor Author

HaoruXue commented Aug 10, 2022

As discussed with @mitsudome-r last week the package is renamed to base_interface to avoid any confusion with existing vehicle interfaces

@brkay54
Copy link
Member

brkay54 commented Aug 22, 2022

Sorry I couldn't review this PR because I was busy with other works. And, I can not review for next 2 week because I am going to take annual leave.

@brkay54
Copy link
Member

brkay54 commented Sep 5, 2022

Hello again, It seems that I am not going to available this month because of vehicle tests. So, I won't be able to review this PR. I am sorry for that.

@brkay54 brkay54 removed their request for review September 5, 2022 10:21
@mitsudome-r
Copy link
Member

@Sharrrrk @brkay54 I'm planning to finish review this week. Would you like to take a look before I merge it after the review?

@stale
Copy link

stale bot commented Jan 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jan 15, 2023
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 1, 2024
@mitsudome-r
Copy link
Member

Since there were no action for long time, I'm closing the PR.
We can reopen it if we need the feature again.

@mitsudome-r mitsudome-r closed this Dec 3, 2024
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned)
Projects
Development

Successfully merging this pull request may close these issues.

3 participants