-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(base_interface): add base_interface package #1512
Conversation
a4d3a24
to
02b33ec
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1512 +/- ##
==========================================
+ Coverage 10.72% 10.83% +0.11%
==========================================
Files 1115 1120 +5
Lines 78832 79111 +279
Branches 18561 18727 +166
==========================================
+ Hits 8454 8575 +121
- Misses 61516 61706 +190
+ Partials 8862 8830 -32
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
…interface Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
Signed-off-by: Haoru Xue <haoru.xue@autoware.org>
6c86ce2
to
2db00a3
Compare
As discussed with @mitsudome-r last week the package is renamed to |
Sorry I couldn't review this PR because I was busy with other works. And, I can not review for next 2 week because I am going to take annual leave. |
Hello again, It seems that I am not going to available this month because of vehicle tests. So, I won't be able to review this PR. I am sorry for that. |
This pull request has been automatically marked as stale because it has not had recent activity. |
…oundation#8758) (autowarefoundation#1512) * fix same point Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Since there were no action for long time, I'm closing the PR. |
Signed-off-by: Haoru Xue haoru.xue@autoware.org
Description
Adds
base_interface
package to Autoware.UniverseRelated links
#1451
Tests performed
New tests are included in this package.
Notes for reviewers
According to the architecture design, Autoware is missing an
ActuationStatus
message as a feedback back to control modules, which may need further discussion on.StationaryLockingCommand
, if still needed, may be missing a correspondingStationaryLockingReport
.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.