Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add readme (#756) #135

Merged
merged 2 commits into from
Dec 8, 2021
Merged

docs: add readme (#756) #135

merged 2 commits into from
Dec 8, 2021

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Dec 7, 2021

Signed-off-by: kosuke murakami kosuke.murakami@tier4.jp

Related Issue(required)

Description(required)

Review Procedure(required)

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@taikitanaka3
Copy link
Contributor

@wep21
you need to commit using "feat: add readme" message

@wep21 wep21 changed the title add readme (#756) feat: add readme (#756) Dec 7, 2021
@tkimura4 tkimura4 changed the title feat: add readme (#756) feat: add readme in external cmd selector #756 Dec 7, 2021
@wep21 wep21 changed the title feat: add readme in external cmd selector #756 docs: add readme (#756) Dec 7, 2021
Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@1222-takeshi 1222-takeshi enabled auto-merge (squash) December 8, 2021 01:59
@1222-takeshi 1222-takeshi merged commit d713056 into autowarefoundation:tier4/proposal Dec 8, 2021
@wep21 wep21 deleted the 756-AAP branch December 8, 2021 02:17
1222-takeshi added a commit to 1222-takeshi/autoware.universe that referenced this pull request Dec 8, 2021
Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Signed-off-by: 1222-takeshi <m.takeshi1995@gmail.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
…operation (autowarefoundation#135)

* Revert "fix(trajectory_follower): change stop check speed threshold to almost 0 (autowarefoundation#246)"

This reverts commit 0cdd76c.

* Revert "fix(trajectory_follower): change stop check speed threshold to 0 (autowarefoundation#232)"

This reverts commit 3bd7d8f.

Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Oct 14, 2022
…utowarefoundation#135)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 28, 2022
…utowarefoundation#135)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 16, 2023
…utowarefoundation#135)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 16, 2023
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
knzo25 pushed a commit to knzo25/autoware.universe that referenced this pull request May 17, 2024
…#135)

* fix(hesai_hw_monitor): merge timers to fix race condition accessing TCP driver

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>

* fix(hesai_launch_component.launch.xml): launch HW monitor in the default component launch config

---------

Signed-off-by: Max SCHMELLER <max.schmeller@tier4.jp>
Co-authored-by: Max SCHMELLER <max.schmeller@tier4.jp>
ryuichi-maeda pushed a commit to sensefield/autoware.universe that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants