Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: to improve the readability of the documentation, unified the name of the sensor_kit repository to YOUR_SENSOR_KIT_launch #561

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

masahiro-kubota
Copy link
Contributor

@masahiro-kubota masahiro-kubota commented Jun 2, 2024

Description

According to autoware.repos, the structure is as follows:

YOUR_SENSOR_KIT_launch/
├── YOUR_SENSOR_KIT_description/
└── YOUR_SENSOR_KIT_launch/

image

Made changes because the documentation described the structure as follows before the changes:

YOUR_SENSOR_KIT_description/
├── YOUR_SENSOR_KIT_description/
└── YOUR_SENSOR_KIT_launch/

image

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@masahiro-kubota masahiro-kubota requested a review from kminoda June 2, 2024 07:57
@masahiro-kubota masahiro-kubota changed the title fix: To improve the readability of the documentation, unified the name of the sensor_kit repository to YOUR_SENSOR_KIT_launch fix: to improve the readability of the documentation, unified the name of the sensor_kit repository to YOUR_SENSOR_KIT_launch Jun 2, 2024
@kminoda kminoda added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) and removed tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) labels Jun 3, 2024
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

…e of the sensor_kit repository to YOUR_SENSOR_KIT_launch

Signed-off-by: Masahiro Kubota <norikenpi@gmail.com>
@masahiro-kubota masahiro-kubota force-pushed the modify-sensor-kit-name branch from 598ce99 to 295d735 Compare June 3, 2024 10:06
@masahiro-kubota masahiro-kubota merged commit 78a71d1 into main Jun 3, 2024
9 checks passed
@masahiro-kubota masahiro-kubota deleted the modify-sensor-kit-name branch June 3, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants