Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rosbag-replay-simulation): add warnings about timestamp discrepancies and pre-playback messages #532

Conversation

ahmeddesokyebrahim
Copy link
Contributor

@ahmeddesokyebrahim ahmeddesokyebrahim commented Mar 12, 2024

Description

This PR is one of group of PRs that aim to fix Autoware logging system to achieve the goal of reducing excessive error and warning logs on Autoware launch.

Part of:

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the 5539-docs-log-messages-rosbag-replay-simulation branch from 0333b58 to 9eeb8e6 Compare March 12, 2024 12:32
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the 5539-docs-log-messages-rosbag-replay-simulation branch from 9eeb8e6 to 12f641d Compare March 12, 2024 12:34
ahmeddesokyebrahim and others added 2 commits March 12, 2024 14:35
…tion log messages

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai>
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the 5539-docs-log-messages-rosbag-replay-simulation branch from 12f641d to 2dd0982 Compare March 12, 2024 12:35
@ahmeddesokyebrahim ahmeddesokyebrahim added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) and removed tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) labels Mar 12, 2024
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the 5539-docs-log-messages-rosbag-replay-simulation branch from c9ac974 to 56330dc Compare March 12, 2024 12:44
@ahmeddesokyebrahim
Copy link
Contributor Author

@xmfcx
I am facing a problem with autofix commits.

  • When the !!! warning is in the same indentation with numbering, it fails to see the order and hence expects point # 2 to be # 1.

  • When the !!! warning is in the same indentation with the text above it, it deletes the space under !!! warning and makes the warning message as same indentation as !!! warning .

@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the 5539-docs-log-messages-rosbag-replay-simulation branch 4 times, most recently from ea709a1 to 2dd0982 Compare March 12, 2024 13:19
@xmfcx xmfcx changed the title docs(log-messages): log messags hints for rosbag replay simulation users docs(rosbag-replay-simulation): add warnings about timestamp discrepancies and pre-playback messages Mar 12, 2024
@xmfcx xmfcx force-pushed the 5539-docs-log-messages-rosbag-replay-simulation branch 4 times, most recently from d3a1ee9 to 18efaa5 Compare March 12, 2024 14:35
@xmfcx xmfcx force-pushed the 5539-docs-log-messages-rosbag-replay-simulation branch 3 times, most recently from b895a87 to d193616 Compare March 12, 2024 14:54
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx force-pushed the 5539-docs-log-messages-rosbag-replay-simulation branch from a9fa560 to 98f248d Compare March 12, 2024 15:09
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx merged commit deab0c3 into autowarefoundation:main Mar 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants