-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(rosbag-replay-simulation): add warnings about timestamp discrepancies and pre-playback messages #532
Merged
xmfcx
merged 7 commits into
autowarefoundation:main
from
ahmeddesokyebrahim:5539-docs-log-messages-rosbag-replay-simulation
Mar 12, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmfcx
reviewed
Mar 12, 2024
xmfcx
reviewed
Mar 12, 2024
0333b58
to
9eeb8e6
Compare
9eeb8e6
to
12f641d
Compare
…tion log messages Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai>
12f641d
to
2dd0982
Compare
c9ac974
to
56330dc
Compare
@xmfcx
|
ea709a1
to
2dd0982
Compare
Signed-off-by: Ahmed Ebrahim <ahmed.ebrahim@leodrive.ai>
d3a1ee9
to
18efaa5
Compare
b895a87
to
d193616
Compare
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
a9fa560
to
98f248d
Compare
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
xmfcx
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is one of group of PRs that aim to fix Autoware logging system to achieve the goal of reducing excessive error and warning logs on Autoware launch.
Part of:
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.