Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update parameters.md coding guidelines #434

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

kaspermeck-arm
Copy link
Contributor

@kaspermeck-arm kaspermeck-arm commented Aug 14, 2023

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaspermeck-arm thanks!

Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaspermeck-arm changes look ok, but this PR is failing the DCO check. Could you sign each of your commits with git commit -s ? Thanks.

@kaspermeck-arm kaspermeck-arm force-pushed the kaspermeck-arm-patch-1 branch from d375744 to 450657e Compare August 17, 2023 22:19
@kaspermeck-arm
Copy link
Contributor Author

@kaspermeck-arm changes look ok, but this PR is failing the DCO check. Could you sign each of your commits with git commit -s ? Thanks.

@esteve - done!

@kaspermeck-arm
Copy link
Contributor Author

@esteve - I addressed the DCO issue, can you take a look now?

@esteve esteve changed the title Update parameters.md coding guidelines docs: update parameters.md coding guidelines Aug 22, 2023
@esteve esteve force-pushed the kaspermeck-arm-patch-1 branch from 450657e to 418c82b Compare August 22, 2023 08:17
@esteve
Copy link
Contributor

esteve commented Aug 22, 2023

@kaspermeck-arm thanks. I've updated the title of the PR so that it follows our conventions (merging was blocked because of that). I believe you'd have to update the comment in the first commit to match it, but not entirely sure. I've rebased the PR, which triggered another CI run, we'll see if updating the title is enough.

kaspermeck-arm and others added 3 commits August 22, 2023 13:24
Signed-off-by: kaspermeck-arm <kasper.mecklenburg@arm.com>
Signed-off-by: kaspermeck-arm <kasper.mecklenburg@arm.com>
Signed-off-by: kaspermeck-arm <kasper.mecklenburg@arm.com>
@esteve esteve force-pushed the kaspermeck-arm-patch-1 branch from 418c82b to 6277cd0 Compare August 22, 2023 11:24
@esteve
Copy link
Contributor

esteve commented Aug 22, 2023

@kaspermeck-arm it seems that the DCO check doesn't work well if the changes had been committed via the GitHub website and you have your email address masked. Anyway, I've marked the check. Thanks!

@esteve esteve merged commit fc6a184 into main Aug 22, 2023
@esteve esteve deleted the kaspermeck-arm-patch-1 branch August 22, 2023 11:28
@kaspermeck-arm
Copy link
Contributor Author

@esteve - I see, I'll keep that in mind for next time! Thanks for reviewing and merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants