-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update parameters.md coding guidelines #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaspermeck-arm thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kaspermeck-arm changes look ok, but this PR is failing the DCO check. Could you sign each of your commits with git commit -s
? Thanks.
d375744
to
450657e
Compare
@esteve - done! |
450657e
to
418c82b
Compare
@kaspermeck-arm thanks. I've updated the title of the PR so that it follows our conventions (merging was blocked because of that). I believe you'd have to update the comment in the first commit to match it, but not entirely sure. I've rebased the PR, which triggered another CI run, we'll see if updating the title is enough. |
Signed-off-by: kaspermeck-arm <kasper.mecklenburg@arm.com>
Signed-off-by: kaspermeck-arm <kasper.mecklenburg@arm.com>
Signed-off-by: kaspermeck-arm <kasper.mecklenburg@arm.com>
418c82b
to
6277cd0
Compare
@kaspermeck-arm it seems that the DCO check doesn't work well if the changes had been committed via the GitHub website and you have your email address masked. Anyway, I've marked the check. Thanks! |
@esteve - I see, I'll keep that in mind for next time! Thanks for reviewing and merging :) |
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.