Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove description about divided maps and put link instead #429

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Aug 1, 2023

Description

Related to #424.

Current map design doc include a specific guideline for how to divide maps for Autoware, which seems to be out of the scope of the design doc. Furthermore, the same description is included in the readme in Autoware Universe, making it more difficult to maintain both documentation properly.

Thus, I'd like to remove the specific description in Autoware Documentation and put a link to readme instead.

One of the alternatives would be to leave this documentation as it is, and put the link to this page in Readme instead. However, given that the most of the package description is included in Readme and not in Documentation page, I'd like to take the former approach to be consistent with other packages.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda requested a review from SakodaShintaro August 1, 2023 02:41
@kminoda kminoda self-assigned this Aug 1, 2023
@kminoda kminoda marked this pull request as ready for review August 1, 2023 02:41
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 65bb0bf into main Aug 1, 2023
@kminoda kminoda deleted the feat/remove_description_about_divided_maps branch August 1, 2023 02:51
alanmengg pushed a commit to alanmengg/autoware-documentation that referenced this pull request Aug 2, 2023
…owarefoundation#429)

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: guiping meng <alan.meng@autocore.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants