docs(launch-autoware): add how to launch yabloc or eagleye #411

KYabuuchi · 2023-06-27T02:51:33Z

Description

Added a new page: "How to guides/5. Launch Autoware".
Organized the startup procedures for YabLoc and Eagleye and made changes to the page hierarchy.
Provided additional details about YabLoc.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

github-actions · 2023-06-27T02:53:59Z

Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-411/
Modified URLs:

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

KYabuuchi · 2023-06-27T05:07:00Z

Hi! This PR is now ready for review.

I would like each of you to review the following: 🙏
@yukkysaito @mitsudome-r : the hierarchy structure of the documentation pages.
@rsasaki0109 : about Eagleye. Specifically, "Localization mode" and "Eagleye guide".

yukkysaito · 2023-06-27T05:17:53Z

@KYabuuchi Thank you for your PR. LGTM 👍

KYabuuchi · 2023-06-27T05:28:57Z

@kminoda I hope you take a look at "YabLoc" and "Localization mode" 🙏

kminoda

Cool!! Thank you for the document 🙏
Maybe this comment be better to handled first #411 (comment)

docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/yabloc-guide.md

docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/index.md

docs/how-to-guides/integrating-autoware/launch-autoware/localization-mode/yabloc-guide.md

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

KYabuuchi · 2023-06-28T01:57:20Z

@kminoda I have moved the introduction of YabLoc to the README in autoware.universe. The reviews pointed out have been reflected there. autowarefoundation/autoware.universe#4100

kminoda

LGTM!!

Let me ask you one question in slack

kminoda

I once dismissed the approval since I got confused with the localization_mode and pose_estimator_mode, but now it's clear that it's not an error (complicated though), so LGTM again!

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

KYabuuchi · 2023-06-30T00:40:33Z

@rsasaki0109 Hi. I made some minor updates to the Eagleye page, so I would appreciate a quick review to ensure everything looks good. 🙇 🙏

rsasaki0109 · 2023-07-05T02:06:30Z

Sorry. I did not notice the notification. I will check.

rsasaki0109

@KYabuuchi
This PR looks very good to me.
There are no issues to point out.

…oundation#411) * add yabloc page but it's empty Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * update yabloc-integration-guide Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * style(pre-commit): autofix * add what is YabLoc Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * moved yabloc and eagleye docs under launch-autoware Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * WIP add some descriptions in Japanese Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * WIP update Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * modified structure Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * translate in english Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * applied pre-commit Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix typo Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * fix typo again Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * reflected reviews Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * removed yabloc sub-page Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * add comprehensive table Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * use markdown rather than html Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * i dont know why the table does not appear Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * update table Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * today's CI is annoying Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> * split table Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> --------- Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: guiping meng <alan.meng@autocore.ai>

KYabuuchi and others added 10 commits June 27, 2023 11:45

add yabloc page but it's empty

d77181f

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

update yabloc-integration-guide

941b587

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

style(pre-commit): autofix

c03704f

add what is YabLoc

74ba81b

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

moved yabloc and eagleye docs under launch-autoware

eebf53e

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

WIP add some descriptions in Japanese

e297470

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

WIP update

6529964

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

modified structure

e85601a

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

translate in english

9a44444

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

applied pre-commit

19c4a6d

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

KYabuuchi requested a review from rsasaki0109 June 27, 2023 02:51

KYabuuchi added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) component:localization Vehicle's position determination in its environment. labels Jun 27, 2023

KYabuuchi changed the title ~~Docs/how to launch yabloc or eagleye~~ docs(launch-autoware): how to launch yabloc or eagleye Jun 27, 2023

KYabuuchi changed the title ~~docs(launch-autoware): how to launch yabloc or eagleye~~ docs(launch-autoware): add how to launch yabloc or eagleye Jun 27, 2023

KYabuuchi added 2 commits June 27, 2023 11:59

fix typo

124c385

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

fix typo again

b3ab964

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

KYabuuchi marked this pull request as ready for review June 27, 2023 04:57

KYabuuchi requested a review from kminoda June 27, 2023 05:26

kminoda reviewed Jun 27, 2023

View reviewed changes

KYabuuchi added 2 commits June 27, 2023 18:21

reflected reviews

50ff60b

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

removed yabloc sub-page

bb8feb7

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

KYabuuchi mentioned this pull request Jun 28, 2023

docs(yabloc): update yabloc readme autowarefoundation/autoware.universe#4100

Merged

4 tasks

kminoda previously approved these changes Jun 28, 2023

View reviewed changes

kminoda approved these changes Jun 29, 2023

View reviewed changes

KYabuuchi added 3 commits June 29, 2023 11:21

add comprehensive table

b81ddc1

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

use markdown rather than html

5113169

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

i dont know why the table does not appear

4887871

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

KYabuuchi added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) and removed tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) component:localization Vehicle's position determination in its environment. labels Jun 29, 2023

KYabuuchi added 3 commits June 29, 2023 12:00

update table

b82cab6

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

today's CI is annoying

3763b97

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

split table

e84e8be

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>

KYabuuchi mentioned this pull request Jun 29, 2023

docs(yabloc): add yabloc guide #394

Closed

4 tasks

rsasaki0109 approved these changes Jul 5, 2023

View reviewed changes

KYabuuchi merged commit acda2fe into autowarefoundation:main Jul 5, 2023

KYabuuchi deleted the docs/how_to_launch_yabloc_or_eagleye branch July 5, 2023 04:02

tier4-autoware-public-bot bot mentioned this pull request Jul 6, 2023

chore: sync upstream tier4/autoware-documentation#41

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(launch-autoware): add how to launch yabloc or eagleye #411

docs(launch-autoware): add how to launch yabloc or eagleye #411

KYabuuchi commented Jun 27, 2023 •

edited

Loading

github-actions bot commented Jun 27, 2023 •

edited

Loading

KYabuuchi commented Jun 27, 2023

yukkysaito commented Jun 27, 2023

KYabuuchi commented Jun 27, 2023

kminoda left a comment •

edited

Loading

KYabuuchi commented Jun 28, 2023

kminoda left a comment

kminoda left a comment

KYabuuchi commented Jun 30, 2023

rsasaki0109 commented Jul 5, 2023

rsasaki0109 left a comment •

edited

Loading

docs(launch-autoware): add how to launch yabloc or eagleye #411

docs(launch-autoware): add how to launch yabloc or eagleye #411

Conversation

KYabuuchi commented Jun 27, 2023 • edited Loading

Description

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

github-actions bot commented Jun 27, 2023 • edited Loading

KYabuuchi commented Jun 27, 2023

yukkysaito commented Jun 27, 2023

KYabuuchi commented Jun 27, 2023

kminoda left a comment • edited Loading

Choose a reason for hiding this comment

KYabuuchi commented Jun 28, 2023

kminoda left a comment

Choose a reason for hiding this comment

kminoda left a comment

Choose a reason for hiding this comment

KYabuuchi commented Jun 30, 2023

rsasaki0109 commented Jul 5, 2023

rsasaki0109 left a comment • edited Loading

Choose a reason for hiding this comment

KYabuuchi commented Jun 27, 2023 •

edited

Loading

github-actions bot commented Jun 27, 2023 •

edited

Loading

kminoda left a comment •

edited

Loading

rsasaki0109 left a comment •

edited

Loading