Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dds-config): improve dds configuration documentation #373

Merged
merged 1 commit into from
May 18, 2023

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented May 17, 2023

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx added type:documentation Creating or refining documentation. type:new-feature New functionalities or additions, feature requests. tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) labels May 17, 2023
@xmfcx xmfcx requested a review from mitsudome-r May 17, 2023 15:09
@xmfcx xmfcx self-assigned this May 17, 2023
@xmfcx
Copy link
Contributor Author

xmfcx commented May 17, 2023

This is ready for reviewing.

@mitsudome-r mitsudome-r merged commit e6d500c into main May 18, 2023
@mitsudome-r mitsudome-r deleted the improve-dds-config branch May 18, 2023 00:06
alanmengg pushed a commit to alanmengg/autoware-documentation that referenced this pull request Aug 2, 2023
…undation#373)

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: guiping meng <alan.meng@autocore.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. type:new-feature New functionalities or additions, feature requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants