Angular14 Upgrade

[Rlcolli4]

Changes

• package.json packages were updated to be Angular 14 or higher versions
• Other dependencies were updated to their latest versions for compatibility
• Changed version number to 6.0.0
• Added a pending version number and notes to the change log.

References

• Issue 712
• Issue 697

Checklist

• I have read the Auth0 general contribution guidelines
• I have read the Auth0 Code of Conduct
• All code quality tools/guidelines in the CONTRIBUTING documentation have been run/followed
• All relevant assets have been compiled as directed in the CONTRIBUTING documentation, if applicable

[demkalkov]

Please replace tslint with eslint

[Rlcolli4]

I'll fix this as soon as I can. I didn't remove it intentionally, I forked the master branch and did the upgrade. It's probably something I have locally that did it without my knowledge.

[Rlcolli4]

Just migrated from tslint/codelyzer to eslint. Added lint back to places in the angular.json based on steps and documentation for converting.

[MumiaIrrequieta]

Can we ask @Sambego to review and merge this? "auth0/developer-relations-admin" link is dead so maybe no one is receiving the notifications and he's the latest user to commit to this project.
Thanks.

[juvegitau]

@Sambego are in a position to merge?

[frederikprijck]

Thanks for the PR. As mentioned in #712 , apologies about the radio silence here.

Could you also update the package-lock.json file to remove all the entries to npmjs.sitesusa.local?

[frederikprijck]

Doing a fresh pull from this branch, removing the lock file followed by npm i results in an error.

The following changes should solve that, can you update the PR to incorporate these as well?

• Set jasmine-core to ~3.8.0
• Set karma-jasmine-html-reporter to ^1.7.0

Thanks!

[Rlcolli4]

I updated the package.json and angular.json as requested! The two latest commits handled the reversion and then any other changes I needed to get npm start, npm run build, npm run e2e (which does appear to be out of date, its looking for text that I couldn't find anywhere in the app), and npm run test to work.

[frederikprijck]

Running npm run lint throws an exception, can you look into this (should be solved if you solve the comments I made above)?

Let's also ignore e2e for now, I see what you mean. It probably wasn't intended to work.

Btw, I know this PR is abit old, and I don't expect you to keep putting effort here to get this merged. Let me know if you want me to patch it as needed for you. That said, more than happy to leave it to you, just feel free to let me know!

[Rlcolli4]

@frederikprijck I'll take a look at these this afternoon. I don't mind continuing to improve this PR if it helps your team focus on getting settled with the project. I am on the west coast of the US so I apologize if these responses appear as being "late".

[Rlcolli4]

Alright fixed the linting stuff for you, it looks like I didn't run the eslint conversion correctly for some of the projects. I re-ran the conversion and stuff looks good and the npm run lint command doesn't error any more.

[frederikprijck]

Thanks for the PR 🚀 . Can you resolve the conflict and then we should be good to merge.

[Rlcolli4]

Merge is done

[frederikprijck]

First of all, thanks for the PR. Really appreciate the effort here, as this has been a PR of high quality.

I had a conversation with the Angular team and concluded the following:

• When you compile an SDK with Angular 14 and compilationMode set to partial, the SDK will only work with Angular 14+.

However, as we still need to support Angular 12 and 13, it appears to be that we have two options:

• Create a separate version for every major version of Angular
• Compile using the lowest supported Angular version, currently being 12.

Given we have no specific features from angular apart from a service and an interceptor, I believe we should be fine to stick with Angular 12.

However, that would mean we can not merge this PR yet, but can only do so once Angular has dropped support for Angular 12 and 13. Maintaining multiple versions comes with a cost that is not worth it for our SDK.

I feel a bit bad about that, because of the fact that this PR has been open for so long, and all I wanted was get some activity in here and progress the repository as well as get your work in. But I believe we should not merge this PR because of what is mentioned above. I hope you understand the reasoning, and my sincere apologies.

That said, we will bump everything to Angular 12, compile using partial mode and get rid of the legacy warning when compiling.

We can update this PR, drop a couple of commits and use this PR to upgrade to Angular 12, if you like. But I don't want to waste anymore of your time, if you feel like it's wasted.

[frederikprijck]

Closing in favor of #735 and #734