Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 11 SUPPORT #697

Closed
blindsz opened this issue Apr 17, 2021 · 12 comments
Closed

Angular 11 SUPPORT #697

blindsz opened this issue Apr 17, 2021 · 12 comments

Comments

@blindsz
Copy link

blindsz commented Apr 17, 2021

Hi, when can we expect angular 11 support??

@AnthonyNahas
Copy link

I am currently using angular v11 and I am not facing any issues....

@jimyhdolores
Copy link

I use Angular 11 and I have problems, the configuration that is added to the JwtModule does not react, it does nothing.

In Angular 10 I did not have this problem, I created a project from scratch with angular 11 and it did not work either, so the library only works until version 10, I hope you can review this problem

@danielicy
Copy link

in angular 1 1 got: node_modules/angular2-jwt/angular2-jwt.d.ts:1:77 - error TS2307: Cannot find module '@angular/http' or its corresponding type declarations.

@jongbonga
Copy link

I'm using angular 12 without issue

@Yicong-Huang
Copy link

confirmed with angular 11 without issue.

@Rlcolli4
Copy link

Rlcolli4 commented Dec 28, 2021

We've used this package with Angular 10 and 13 without issue. Have you made sure to install the right version? If you use version 4.2.0 it should work.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label Apr 16, 2022
@edbzn
Copy link

edbzn commented Apr 25, 2022

Hi, it's still an issue for us, we are waiting for the Ivy support using the partial compilation mode.

@Rlcolli4
Copy link

Rlcolli4 commented Jun 3, 2022

@edbzn sre you using auth0/angular-jwt or auth0/angular2-jwt? For Ivy our team had to switch to the newer version to work with the Ivy compiler - it didn't take us long to switch over in our projects. Here is the versions we are currently running:
"@angular/core": "~13.1.1"
"@angular/cli": "^13.1.2",
"rxjs": "^6.5.2",
"@auth0/angular-jwt": "5.0.2",

@stale stale bot removed the closed:stale Issue or PR has not seen activity recently label Jun 3, 2022
@edbzn
Copy link

edbzn commented Jun 3, 2022

@Rlcolli4 @auth0/angular-jwt@5.0.2 was published with ViewEngine which means ngcc needs to be run by the consumer to bring Ivy compatibility, here is the log of the webpack plugin processing angular-jwt using ngcc:

⠙ Generating browser application bundles (phase: setup)...
- @auth0/angular-jwt [es2015/esm2015] (git+https://github.com/auth0/angular2-jwt) 

If we want to get rid of ngcc one day we have to encourage library authors to publish using the partial compilation mode.

@Rlcolli4
Copy link

Rlcolli4 commented Jun 3, 2022

Interesting, we haven't seen that when we run locally or when we send a build out. Maybe we have missed it. I will double check our outputs, but currently we do not have any issue running that in our set up.

@Rlcolli4 Rlcolli4 mentioned this issue Jun 3, 2022
4 tasks
@frederikprijck
Copy link
Member

Closing this in favor of #712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants