Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade angular to v11 #714

Closed
wants to merge 1 commit into from

Conversation

celian-garcia
Copy link

@celian-garcia celian-garcia commented Jan 5, 2022

Hi, thanks for this library, I'm planning to update progressively until Angular v13, with one commit by Angular version (one for v11, on for v12, one for v13). I plan to move linter to eslint in the Angular v12 commit.
Please tell me if you agree with these changes and thus if I can continue or not.

The objective is at the end to get rid of the warning in v13 #712

Cheers!

Changes

  • Upgraded Angular to v11 using ng update

References

  • Probably fixes this Angular 11 SUPPORT #697, even though I think it works perfectly with Angular 11 as we ran our frontend on Angular 11 without issue for monthes.

Checklist

@celian-garcia celian-garcia requested a review from a team as a code owner January 5, 2022 15:24
@celian-garcia celian-garcia changed the title Upgrade angular Upgrade angular to v11 Jan 5, 2022
@PedroS5499
Copy link

why this taking so long?

@celian-garcia
Copy link
Author

celian-garcia commented Mar 5, 2022

why this taking so long?

I agree it's a bit long, I'm wondering if it's still maintained. To be honest I'm considering making a fork.

Hello @Sambego, sorry I mention you as you are the last commiter. I'd like to remind you the fact that Angular 10 is not anymore an LTS, and so doesn't receive any security updates, according to the Angular Support Policy documentation.
image

If Auth0 still uses this project, it should be updated for sure!

@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

@stale stale bot added the closed:stale Issue or PR has not seen activity recently label Jun 12, 2022
@PedroS5499
Copy link

No no, no stale

@stale stale bot removed the closed:stale Issue or PR has not seen activity recently label Jun 12, 2022
@celian-garcia
Copy link
Author

@PedroS5499 did you find a substitute ? I don't want to maintain a fork so I will search for another lib or maybe integrate stuff in my code place.

@frederikprijck
Copy link
Member

Closing this in favor of #712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants