Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CredentialManager: add hasValidRefreshToken() method #701

Closed
wants to merge 1 commit into from

Conversation

AndrewSB
Copy link

@AndrewSB AndrewSB commented Jun 3, 2022

Version 2.0.0 of the SDK dropped checking for refresh tokens (#574)

Without this, there's no synchronous way to tell if the stored credential
can be refreshed, even if isValid() returns false.

@AndrewSB AndrewSB requested a review from a team as a code owner June 3, 2022 02:25
Without this, there's no synchronous way to tell if the stored credential
can be refreshed, even if `isValid()` returns false.
@Widcket
Copy link
Contributor

Widcket commented Jun 4, 2022

Hi @AndrewSB , thank you for the report but we're missing some important information. Please re-open a new PR with a completed PR template. Delete sections that are not relevant, ask for help for sections that are not clear, and check all required checkboxes.

Please explain your use case for this feature in detail as well.

@Widcket Widcket closed this Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants