Do not check for Refresh Token presence in hasValid(minTTL:)
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently, the
hasValid(minTTL:)method of the Credentials Manager returnstrueif there is a Refresh Token present. That makes it unusable in practice for the customers that use Refresh Tokens, because then there's no reliable way to tell if the credentials have expired or will expire in a given timeframe.This PR removes the Refresh Token presence check from
hasValid(minTTL:), and thehasValid(minTTL:)calls beforeself.retrieveCredentials()(becauseself.retrieveCredentials()does the same checks inside).See https://auth0team.atlassian.net/browse/ESD-15401?focusedCommentId=406799
Testing
Checklist