Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve access_denied error handling by using the description #494

Merged
merged 2 commits into from
Jun 30, 2021

Conversation

lbalmaceda
Copy link
Contributor

Changes

When the access_denied error is received from the server, the description was hardcoded and the one sent from the server, if available, ignored. This PR changes that.

References

Closes #493

Testing

  • This change adds unit test coverage

  • This change adds integration test coverage

  • This change has been tested on the latest version of the platform/language or why not

Checklist

@lbalmaceda lbalmaceda added CH: Fixed small Small review labels Jun 29, 2021
@lbalmaceda lbalmaceda added this to the v2-Next milestone Jun 29, 2021
@lbalmaceda lbalmaceda requested a review from a team as a code owner June 29, 2021 14:42
@lbalmaceda lbalmaceda merged commit 5487ddc into main Jun 30, 2021
@lbalmaceda lbalmaceda deleted the use-err-description branch June 30, 2021 14:22
@lbalmaceda lbalmaceda modified the milestones: v2-Next, 2.3.0 Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Fixed small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong handing of errors in OAuthManager.assertNoError(errorValue: String?, errorDescription: String?) method
3 participants