Merge pull request #494 from auth0/use-err-description

Improve access_denied error handling by using the description
auth0 · Jun 30, 2021 · 5487ddc · 5487ddc
2 parents 79743a3 + cde91d0
commit 5487ddc
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/auth0/src/main/java/com/auth0/android/provider/OAuthManager.kt b/auth0/src/main/java/com/auth0/android/provider/OAuthManager.kt
@@ -197,7 +197,7 @@ internal class OAuthManager(
             ERROR_VALUE_ACCESS_DENIED.equals(errorValue, ignoreCase = true) -> {
                 throw AuthenticationException(
                     ERROR_VALUE_ACCESS_DENIED,
-                    "Permissions were not granted. Try again."
+                    errorDescription ?: "Permissions were not granted. Try again."
                 )
             }
             ERROR_VALUE_UNAUTHORIZED.equals(errorValue, ignoreCase = true) -> {

diff --git a/auth0/src/test/java/com/auth0/android/provider/WebAuthProviderTest.kt b/auth0/src/test/java/com/auth0/android/provider/WebAuthProviderTest.kt
@@ -1350,6 +1350,36 @@ public class WebAuthProviderTest {
         )
     }
 
+    @Test
+    public fun shouldFailToResumeLoginWithIntentWithAccessDeniedAndDescription() {
+        login(account)
+            .withState("1234567890")
+            .start(activity, callback)
+        val intent = createAuthIntent(
+            createHash(
+                null,
+                "aToken",
+                null,
+                "urlType",
+                1111L,
+                "1234567890",
+                "access_denied",
+                "email is already associated with another account",
+                null
+            )
+        )
+        Assert.assertTrue(resume(intent))
+        verify(callback).onFailure(authExceptionCaptor.capture())
+        assertThat(
+            authExceptionCaptor.firstValue, `is`(notNullValue())
+        )
+        assertThat(authExceptionCaptor.firstValue.getCode(), `is`("access_denied"))
+        assertThat(
+            authExceptionCaptor.firstValue.getDescription(),
+            `is`("email is already associated with another account")
+        )
+    }
+
     @Test
     public fun shouldFailToResumeLoginWithIntentWithRuleError() {
         login(account)