Move to a JSON client singleton #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0108b7e to
21bcfaf
Compare
jimmyjames
requested changes
Jan 15, 2021
jimmyjames
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GsonProviderhas been historically constructing instances of theGsonclient that were not being shared. This PR changes that into using a kotlin object (thread-safe singleton) that will be reused across the entire library. Since this client property has an internal visibility, classes using it were required to be migrated to kotlin. That includes tests.Depends on #427. Merge that and rebase before reviewing this or review from
97f0099on.