Refactor classes visibility and packages #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62a05e9 to
7d747df
Compare
jimmyjames
requested changes
Jan 14, 2021
c64843e to
8e2f2bc
Compare
jimmyjames
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visibility changes
Public & non-used classes
VoidCallbackwas previously used for web auth, no longer used in public APIs. It's nowinternal.The internal package
The internal package contains classes not meant to be used directly. With Kotlin, these now make use of the internal visibility modifier.
BaseAuthenticationRequestBaseRequestRequestFactoryPackage changes:
These are still used in the AuthenticationAPIClient.
com.auth0.android.authentication.request.ProfileRequesttocom.auth0.android.request.ProfileRequestcom.auth0.android.authentication.request.SignUpRequesttocom.auth0.android.request.SignUpRequest