Remove default healpy dependency. #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## margin #440 +/- ##
=========================================
Coverage ? 98.57%
=========================================
Files ? 28
Lines ? 1615
Branches ? 0
=========================================
Hits ? 1592
Misses ? 23
Partials ? 0 ☔ View full report in Codecov by Sentry. |
delucchi-cmu
added a commit
that referenced
this pull request
Nov 26, 2024
* Remove margin fine filtering. (#435) * Use different methods for healpix manipulation. (#436) * Remove margin fine filtering. * Use different methods for healpix manipulation. * Optional dependency for older healpy fits files. * Allow import of map types. (#437) * Accomodate changes in cds-healpix. * Use radec2pix for healpix pixel calculation. (#438) * Remove default healpy dependency. (#440) * Clean up pre-commit
delucchi-cmu
added a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See astronomy-commons/hats#433
We still need the
healpylibrary to occasionally read older FITS files that may have been written in RING pixelization. Marked as optional dependency, and tests can still run against it if healpy is installed.