Allow import of map types. #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 28 28
Lines 1620 1620
=======================================
Hits 1598 1598
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
hombit
approved these changes
Nov 20, 2024
delucchi-cmu
added a commit
that referenced
this pull request
Nov 21, 2024
* Remove margin fine filtering. * Use different methods for healpix manipulation. * Optional dependency for older healpy fits files. * Allow import of map types. (#437) * Accomodate changes in cds-healpix.
delucchi-cmu
added a commit
that referenced
this pull request
Nov 26, 2024
* Remove margin fine filtering. (#435) * Use different methods for healpix manipulation. (#436) * Remove margin fine filtering. * Use different methods for healpix manipulation. * Optional dependency for older healpy fits files. * Allow import of map types. (#437) * Accomodate changes in cds-healpix. * Use radec2pix for healpix pixel calculation. (#438) * Remove default healpy dependency. (#440) * Clean up pre-commit
delucchi-cmu
added a commit
that referenced
this pull request
Nov 26, 2024
* Remove margin fine filtering. * Use different methods for healpix manipulation. * Optional dependency for older healpy fits files. * Allow import of map types. (#437) * Accomodate changes in cds-healpix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow catalog type on import to be
map.Related to astronomy-commons/hats#429 and astronomy-commons/hats#412