Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #421

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Update dependencies #421

merged 2 commits into from
Oct 29, 2024

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Oct 29, 2024

  • pyyaml was unused
  • scipy is no longer a direct dependency (Move sparse histogram to hipscat #405)
  • ipykernel is a nice-to-have dependency for folks running inside a jupyter notebook
  • but ipywidgets is an even-nicer-to-have dependency
  • extras handles the nice-to-haves, including the full suite of fsspec implementations.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (618c14e) to head (54f9317).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          28       28           
  Lines        1620     1620           
=======================================
  Hits         1598     1598           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 29, 2024

Before [618c14e] After [5f41942] Ratio Benchmark (Parameter)
failed failed n/a benchmarks.BinningSuite.time_read_histogram

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu requested a review from hombit October 29, 2024 15:42
pyproject.toml Outdated Show resolved Hide resolved
@hombit
Copy link
Contributor

hombit commented Oct 29, 2024

Could you please also update Readme and RTD about this new extras?

@delucchi-cmu delucchi-cmu merged commit 5f5f3cb into main Oct 29, 2024
10 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/extras branch October 29, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants