Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sparse histogram to hipscat #405

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

camposandro
Copy link
Collaborator

Move the SparseHistogram implementation that currently resides in the importer to hipscat. LSDB will use it to compute the point map distributions more efficiently.

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@camposandro camposandro self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.73%. Comparing base (526f5c1) to head (d9efe2f).

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #405      +/-   ##
===============================================
- Coverage        99.73%   99.73%   -0.01%     
===============================================
  Files               26       25       -1     
  Lines             1520     1484      -36     
===============================================
- Hits              1516     1480      -36     
  Misses               4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camposandro camposandro merged commit c78674d into development Oct 16, 2024
7 of 8 checks passed
@camposandro camposandro deleted the sandro/move-sparse-histogram branch October 16, 2024 15:11
@delucchi-cmu delucchi-cmu mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants