Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide drop_empty_siblings argument #357

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Provide drop_empty_siblings argument #357

merged 2 commits into from
Jul 31, 2024

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Jul 26, 2024

Change Description

Closes astronomy-commons/hats#302
Closes #269

Solution Description

Adds drop_empty_siblings argument to binning calculation, as added in astronomy-commons/hats#304.

Increases the default highest_order s.t. users are unlikely to need to change it, and clarifies behavior in the docstrings.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (8a34d62) to head (bd9eea8).
Report is 56 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          26       26           
  Lines        1454     1456    +2     
=======================================
+ Hits         1450     1452    +2     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@delucchi-cmu delucchi-cmu merged commit ee02e32 into main Jul 31, 2024
10 checks passed
@delucchi-cmu delucchi-cmu deleted the hipscat/issue/302 branch July 31, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants