Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize histogram binning to not produce large empty tiles #302

Closed
1 of 3 tasks
hombit opened this issue Jul 16, 2024 · 0 comments · Fixed by astronomy-commons/hats-import#357
Closed
1 of 3 tasks
Assignees
Labels
enhancement New feature or request

Comments

@hombit
Copy link
Contributor

hombit commented Jul 16, 2024

Feature request

Currently, count histogram binning works in a greedy way: it merges tiles until 1) the total count is bellow a threshold, 2) minimum order (default is 0) is reached. I believe we can do it smarter and do not merge it further if all tiles but one have zero counts.

It may produce too many partitions for some edge-cases, e.g. very clumpy data in a catalog composed from many individual pointings. However these edge-cases can be solved with a smaller maximum order.

Before submitting
Please check the following:

  • I have described the purpose of the suggested change, specifying what I need the enhancement to accomplish, i.e. what problem it solves.
  • I have included any relevant links, screenshots, environment information, and data relevant to implementing the requested feature, as well as pseudocode for how I want to access the new functionality.
  • If I have ideas for how the new feature could be implemented, I have provided explanations and/or pseudocode and/or task lists for the steps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants