Fix curly bracket spacing around curly f-string expressions #15471
+117
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15459
F-string expression need to leave one space between the element's
{
or}
and any curly braces inside the expression itself or it results in invalid syntax:The existing implementation handles this correctly if the expression itself has curly braces, but it doesn't add the necessary space if the expression starts or ends with an expression with curly parentheses:
This PR changes the formatter to check if the left-most sub expression (if any) starts with curly parentheses instead of just checking the expression itself.
Test Plan
Added snapshot tests.