-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename the ruff_vendored
crate to red_knot_vendored
#13586
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Unrelated to this PR, do we need the vendor
directory inside the red_knot_vendored
crate or should we move the typeshed
at the top-level? The double "vendor" was confusing at first but it's fine regardless.
Yeah, I suppose having the I feel like I still weakly prefer having them in a subdirectory for that reason, but definitely don't have a strong opinion |
I don't think I agree with this. Ruff analyze might need the same vendored files if it wants to detect standard library or third party dependencies. I used this name because ruff will use this crate long term. Although that can be said for an red knot module. TLDR: I don't mind this change. |
Well, I feel like we can consider renaming them again when Ruff and red-knot truly merge, but for now it feels very much like part of the red-knot project to me. And renaming is fairly cheap! |
Summary
Following #13436, @carljm and I are no longer getting automated review requests for typeshed-sync PRs: @dhruvmanila had to manually request my review on #13578. That's because our CODEOWNERs file only has us as "owning" paths that have
red_knot
in them:ruff/.github/CODEOWNERS
Lines 19 to 21 in 2a36b47
We could just add another line to CODEOWNERS, like we already have for
ruff_db
, but renaming the crate has other advantages too:Test Plan
cargo test
ruff_vendored
anywhere.