-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use an empty vendored file system in Ruff #13436
Conversation
5fc44df
to
551ed4d
Compare
@charliermarsh this is a potential short term fix for the conda forge build |
99ecfef
to
eebff71
Compare
|
This appears to be working: conda-forge/ruff-feedstock#220 |
I'm happy to release it today if you want |
Nice. Could you try running the new analyze method over a real project? Just to make sure we don't show annoying warnings when the versions file is empty 😆 |
eebff71
to
23b3b0f
Compare
But yeah. Feel free to merge and release the changes to unblock conda forge. |
For changelog: Fix conda forge build. |
I love your confidence 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I don't understand why it sometimes creates those files but doesn't delete them when the test is done.
Just ran, no warnings :) |
Summary
This PR changes removes the typeshed stubs from the vendored file system shipped with ruff
and instead ships an empty "typeshed".
Making the typeshed files optional required extracting the typshed files into a new
ruff_vendored
crate. I do like this even if all our builds always include typeshed because it meansred_knot_python_semantic
contains less code that needs compiling.This also allows us to use deflate because the compression algorithm doesn't matter for an archive containing a single, empty file.
Test Plan
cargo test
I verified with
cargo tree -f "{p} {f}" -p <package>
that:deflate
compressionzstd
compressionruff
: uses storedI'm not quiet sure how to build the binary that maturin builds but comparing the release artifact size with
strip = true
shows a1.5MB
size reduction