-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Zoho OAuth provider #910
Implement Zoho OAuth provider #910
Conversation
src/AspNet.Security.OAuth.Zoho/ZohoAuthenticationPostConfigureOptions.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Zoho/ZohoAuthenticationPostConfigureOptions.cs
Outdated
Show resolved
Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/Zoho/ZohoAuthenticationPostConfigureOptionsTests.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Zoho/ZohoAuthenticationPostConfigureOptions.cs
Outdated
Show resolved
Hide resolved
Did you try with a user account created in a non-US region? I just added this provider to OpenIddict and it was fairly painful to support that, as you need to make the token and userinfo endpoints dynamic (based on the |
Yes, I did. I have tested with almost all regions. Each region that supports Zoho has its own domain (https://www.zoho.com/accounts/protocol/oauth/multi-dc.html). In my implementation, I configure all necessary endpoints in ZohoAuthenticationPostConfigureOptions.cs file and use hardcoded endpoints for selected region. Do you mean to use this endpoint (https://accounts.zoho.com/oauth/serverinfo) to receive locations or smth else? |
But they are configured statically/globally and are used for all users. Yet, if your application is configured to use the US region and you try to log in with a EU account, you'll get an error during the token request since the client was expected to send that token request to the EU token endpoint and not to the US token endpoint. |
That (stupid) logic is explained here: https://www.zoho.com/accounts/protocol/oauth/multi-dc/client-authorization.html |
Hey, @kevinchalet ! When you get a chance, could you take a look at this pull request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @kevinchalet ! When you get a chance, could you take a look at this pull request?
Hey,
Sorry for the late reply, busy weekend 🤣
Just to confirm, have you tested this works with the real service? |
yep, I just did one more test and it works as expected. |
Thanks again for your contribution. I'll look to do a 8.2.0 release for this and Docusign at some point this weekend. |
The Docusign and Zoho providers are now both available from NuGet.org as part of the 8.2.0 release - thanks again! |
The implementation allows users to authenticate using their Zoho account credentials.