Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Docusign OAuth provider #907

Merged

Conversation

denis-goncharenko
Copy link
Contributor

This feature allows users to authenticate using their Docusign credentials. Tested in production service and works perfectly.

@kevinchalet
Copy link
Member

Tested in production service and works perfectly.

Isn't https://account-d.docusign.com/ DocuSign's dev environment?

We'll need to add an Environment option to allow users to change the environment without having to replace each endpoint manually to use https://account.docusign.com/ instead of https://account-d.docusign.com/.

@denis-goncharenko
Copy link
Contributor Author

Tested in production service and works perfectly.

Isn't https://account-d.docusign.com/ DocuSign's dev environment?

We'll need to add an Environment option to allow users to change the environment without having to replace each endpoint manually to use https://account.docusign.com/ instead of https://account-d.docusign.com/.

You are right. It's my fault I've just tested in prod and then in sandbox and forgot to change it.

I'll add the 'Environment' option.

@denis-goncharenko denis-goncharenko marked this pull request as draft June 15, 2024 14:03
@denis-goncharenko denis-goncharenko marked this pull request as ready for review June 15, 2024 19:37
@denis-goncharenko
Copy link
Contributor Author

I've included the 'Environment' option to facilitate work with development and production environments. I have tested both options, and they work as expected.

@martincostello
Copy link
Member

Could you update the version for 8.2.0 here please as we're adding a new provider?

<MinorVersion>1</MinorVersion>
<PatchVersion>1</PatchVersion>

Otherwise LGTM.

@martincostello martincostello merged commit b1c69b1 into aspnet-contrib:dev Jun 18, 2024
8 checks passed
@martincostello martincostello added this to the 8.2.0 milestone Jun 18, 2024
@denis-goncharenko
Copy link
Contributor Author

Hello @martincostello! When are you planning to create NuGet packages for version 8.2.0?

@martincostello
Copy link
Member

#910 is still WIP so assumed we'd do the release when that was finished too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants