-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Docusign OAuth provider #907
Implement Docusign OAuth provider #907
Conversation
Isn't https://account-d.docusign.com/ DocuSign's dev environment? We'll need to add an |
You are right. It's my fault I've just tested in prod and then in sandbox and forgot to change it. I'll add the 'Environment' option. |
I've included the 'Environment' option to facilitate work with development and production environments. I have tested both options, and they work as expected. |
src/AspNet.Security.OAuth.Docusign/AspNet.Security.OAuth.Docusign.csproj
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Docusign/DocusignAuthenticationConstants.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Docusign/DocusignAuthenticationOptions.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Docusign/DocusignAuthenticationDefaults.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Docusign/DocusignAuthenticationOptions.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Docusign/DocusignAuthenticationOptions.cs
Outdated
Show resolved
Hide resolved
src/AspNet.Security.OAuth.Docusign/DocusignAuthenticationPostConfigureOptions.cs
Outdated
Show resolved
Hide resolved
test/AspNet.Security.OAuth.Providers.Tests/Docusign/DocusignTests.cs
Outdated
Show resolved
Hide resolved
Could you update the version for 8.2.0 here please as we're adding a new provider? AspNet.Security.OAuth.Providers/eng/Versions.props Lines 5 to 6 in 5319292
Otherwise LGTM. |
Hello @martincostello! When are you planning to create NuGet packages for version 8.2.0? |
#910 is still WIP so assumed we'd do the release when that was finished too. |
This feature allows users to authenticate using their Docusign credentials. Tested in production service and works perfectly.