Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: capture and suppress output in installers #186

Merged
merged 1 commit into from
Jan 5, 2025
Merged

improvement: capture and suppress output in installers #186

merged 1 commit into from
Jan 5, 2025

Conversation

zachdaniel
Copy link
Contributor

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@zachdaniel
Copy link
Contributor Author

Some frustrating realities:

I had to copy the same code into the installer as well so that it could do the same loading behavior. We will have to keep that code in sync as we do with the igniter.install task. We can maybe get clever doing something in the compile process, but with the igniter.install task there are subtle differences. For now I've opted to just keep them separate.

@zachdaniel zachdaniel force-pushed the loading-spinners-spike branch from 00aafab to 22f6872 Compare January 5, 2025 16:36
@zachdaniel zachdaniel merged commit c711cd8 into main Jan 5, 2025
18 checks passed
jimsynz pushed a commit to jimsynz/reactor_req that referenced this pull request Jan 6, 2025
@jimsynz
chore(deps): update dependency igniter to v0.5.7 (#110)
ae1415b 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [igniter](https://hex.pm/packages/igniter) ([source](https://github.com/ash-project/igniter)) | patch | `0.5.1` -> `0.5.7` |

---

### Release Notes

<details>
<summary>ash-project/igniter (igniter)</summary>

### [`v0.5.7`](https://github.com/ash-project/igniter/blob/HEAD/CHANGELOG.md#v057-2025-01-06)

[Compare Source](ash-project/igniter@v0.5.6...v0.5.7)

##### Bug Fixes:

-   propertly iterate over tasks list

### [`v0.5.6`](https://github.com/ash-project/igniter/blob/HEAD/CHANGELOG.md#v056-2025-01-05)

[Compare Source](ash-project/igniter@v0.5.5...v0.5.6)

##### Improvements:

-   better step explanation in installer

### [`v0.5.5`](https://github.com/ash-project/igniter/blob/HEAD/CHANGELOG.md#v055-2025-01-05)

[Compare Source](ash-project/igniter@v0.5.4...v0.5.5)

##### Bug Fixes:

-   only display mix.exs changes when showing them

### [`v0.5.4`](https://github.com/ash-project/igniter/blob/HEAD/CHANGELOG.md#v054-2025-01-05)

[Compare Source](ash-project/igniter@v0.5.3...v0.5.4)

##### Bug Fixes:

-   don't show git warning for changes igniter made

-   print message after diff

-   allow check to pass when no issues found ([#&#8203;178](ash-project/igniter#178))

##### Improvements:

-   capture and suppress output in installers ([#&#8203;186](ash-project/igniter#186))

-   print version diff when upgrading packages ([#&#8203;185](ash-project/igniter#185))

-   sort the `missing` packages when upgrading

### [`v0.5.3`](https://github.com/ash-project/igniter/blob/HEAD/CHANGELOG.md#v053-2024-12-26)

[Compare Source](ash-project/igniter@v0.5.2...v0.5.3)

##### Bug Fixes:

-   ensure deps are compiled and proceed w/ install if igniter is

##### Improvements:

-   rip out shared utils

### [`v0.5.2`](https://github.com/ash-project/igniter/blob/HEAD/CHANGELOG.md#v052-2024-12-25)

[Compare Source](ash-project/igniter@v0.5.1...v0.5.2)

##### Improvements:

-   add `--yes-to-deps` option to `mix igniter.install`

-   add `--yes-to-deps` when using `mix igniter.new`

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44My42IiwidXBkYXRlZEluVmVyIjoiMzkuOTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUiXX0=-->

Reviewed-on: https://harton.dev/james/reactor_req/pulls/110
Co-authored-by: Renovate Bot <bot@harton.nz>
Co-committed-by: Renovate Bot <bot@harton.nz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zachdaniel