fix: allow --check to pass when no issues found #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachdaniel
approved these changes
Dec 27, 2024
|
🚀 Thank you for your contribution! 🚀 it’s straightforward so no worries :) |
jimsynz
pushed a commit
to jimsynz/reactor_req
that referenced
this pull request
Jan 6, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [igniter](https://hex.pm/packages/igniter) ([source](https://github.com/ash-project/igniter)) | patch | `0.5.1` -> `0.5.7` | --- ### Release Notes <details> <summary>ash-project/igniter (igniter)</summary> ### [`v0.5.7`](https://github.com/ash-project/igniter/blob/HEAD/CHANGELOG.md#v057-2025-01-06) [Compare Source](ash-project/igniter@v0.5.6...v0.5.7) ##### Bug Fixes: - propertly iterate over tasks list ### [`v0.5.6`](https://github.com/ash-project/igniter/blob/HEAD/CHANGELOG.md#v056-2025-01-05) [Compare Source](ash-project/igniter@v0.5.5...v0.5.6) ##### Improvements: - better step explanation in installer ### [`v0.5.5`](https://github.com/ash-project/igniter/blob/HEAD/CHANGELOG.md#v055-2025-01-05) [Compare Source](ash-project/igniter@v0.5.4...v0.5.5) ##### Bug Fixes: - only display mix.exs changes when showing them ### [`v0.5.4`](https://github.com/ash-project/igniter/blob/HEAD/CHANGELOG.md#v054-2025-01-05) [Compare Source](ash-project/igniter@v0.5.3...v0.5.4) ##### Bug Fixes: - don't show git warning for changes igniter made - print message after diff - allow check to pass when no issues found ([#​178](ash-project/igniter#178)) ##### Improvements: - capture and suppress output in installers ([#​186](ash-project/igniter#186)) - print version diff when upgrading packages ([#​185](ash-project/igniter#185)) - sort the `missing` packages when upgrading ### [`v0.5.3`](https://github.com/ash-project/igniter/blob/HEAD/CHANGELOG.md#v053-2024-12-26) [Compare Source](ash-project/igniter@v0.5.2...v0.5.3) ##### Bug Fixes: - ensure deps are compiled and proceed w/ install if igniter is ##### Improvements: - rip out shared utils ### [`v0.5.2`](https://github.com/ash-project/igniter/blob/HEAD/CHANGELOG.md#v052-2024-12-25) [Compare Source](ash-project/igniter@v0.5.1...v0.5.2) ##### Improvements: - add `--yes-to-deps` option to `mix igniter.install` - add `--yes-to-deps` when using `mix igniter.new` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44My42IiwidXBkYXRlZEluVmVyIjoiMzkuOTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUiXX0=--> Reviewed-on: https://harton.dev/james/reactor_req/pulls/110 Co-authored-by: Renovate Bot <bot@harton.nz> Co-committed-by: Renovate Bot <bot@harton.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #177 (comment)
Is it necessary to regression test this? If so, what would be the best way? I had a problem reproducing the exact same issue in tests but it's easy to reproduce by creating a new project, installing igniter and running
mix igniter.move_files --check.