Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence Ontology functional annotation doc fixes #300

Merged
merged 2 commits into from
Jun 11, 2014

Conversation

heuermh
Copy link
Contributor

@heuermh heuermh commented Jun 11, 2014

I have added links to the Sequence Ontology MISO browser for all the SO terms used in the functional annotation documentation.

In doing so I found a few errors (e.g. feature elongation should be feature_elongation, non_coding_exon_variant should be non_coding_transcript_exon_variant) and at least one term that I could not correct (nc_transcript_variant).

I haven't looked at the GEMINI code yet to see if the same corrections need to be made there, or if these were just documentation errors.

@arq5x
Copy link
Owner

arq5x commented Jun 11, 2014

Fantastic - thanks very much for this, Michael!

We will correct the errors you kindly identified.

arq5x added a commit that referenced this pull request Jun 11, 2014
Sequence Ontology functional annotation doc fixes
@arq5x arq5x merged commit b1ef4f4 into arq5x:master Jun 11, 2014
@heuermh heuermh deleted the so-doc-fixes branch June 11, 2014 18:18
@udp3f
Copy link
Contributor

udp3f commented Jun 11, 2014

Hi,
Hi Michael,

Thanks for adding links to SO terms. As a note, GEMINI stores VEP impacts, the way they are returned/documented by VEP, since they intend to use SO terminology. But for terms like non_coding_exon_variant (rightfully: http://www.sequenceontology.org/browser/current_svn/term/SO:0001792) and nc_transcript_variant (rightfully: http://www.sequenceontology.org/browser/current_svn/term/SO:0001619) they seem to be not returning the correct terms. Since this is a VEP issue, I guess these could be left as such in the documentation, but with the right links in place.
I will try getting in touch with the VEP guys to correct this.
-Uma

@udp3f
Copy link
Contributor

udp3f commented Jun 12, 2014

Hi,
Following up on the above mentioned impacts, these would be fixed in the next release of Ensembl/VEP.
-Uma

czarifis pushed a commit to czarifis/gemini that referenced this pull request Jul 21, 2014
Sequence Ontology functional annotation doc fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants