Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variant effect ontology #261

Closed
fnothaft opened this issue Jun 8, 2014 · 5 comments
Closed

Add variant effect ontology #261

fnothaft opened this issue Jun 8, 2014 · 5 comments

Comments

@fnothaft
Copy link
Member

fnothaft commented Jun 8, 2014

Suggested by @heuermh, see here for examples. This should be added to the VariantAnnotations and variant annotation parser.

@heuermh
Copy link
Member

heuermh commented Jun 8, 2014

My further suggestion would be to only accept SO term names in ADAM and not worry about mapping between non-SO terms as described on that GEMINI documentation page, i.e. only those values from the column Sequence Ontology terms (column: impact_so) in this table

http://gemini.readthedocs.org/en/latest/content/functional_annotation.html#so-impact-definitions-in-gemini

Although on review that column has some errors in it, e.g. feature elongation should be feature_elongation (SO:0001907), non_coding_exon_variant should be non_coding_transcript_exon_variant (SO:0001792), nc_transcript_variant isn't a valid term, etc.

@heuermh
Copy link
Member

heuermh commented Jun 11, 2014

I have been able to fix some of those documentation errors, not sure yet if the GEMINI code also needs to be fixed.

arq5x/gemini#300

In any case, the SO itself should be the source of record for these terms.

@heuermh
Copy link
Member

heuermh commented Oct 7, 2015

See new VCF annotation standard 'ANN' field specification, from authors of SnpEff and Ensembl VEP.

@fnothaft
Copy link
Member Author

fnothaft commented Jul 6, 2016

See new schema in bigdatagenomics/bdg-formats#67.

@fnothaft fnothaft added this to the 0.20.0 milestone Jul 6, 2016
@fnothaft
Copy link
Member Author

fnothaft commented Jul 6, 2016

Closing as dupe of #1044.

@fnothaft fnothaft closed this as completed Jul 6, 2016
@fnothaft fnothaft removed this from the 0.20.0 milestone Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants