Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named supervisor credo check #982

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Conversation

samuelmanzanera
Copy link
Member

Description

This PR adds a credo check to ensure the supervisor are named and fix the un-named supervisors

Fixes #978

How Has This Been Tested?

Omit the commit ea098d3 and run mix credo.
It should report the supervisor which are not named.
After application of the same commit, the mix credo would not return errors.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@samuelmanzanera samuelmanzanera added the quality Improve code quality label Apr 19, 2023
@samuelmanzanera samuelmanzanera force-pushed the add_named_supervisor_credo_check branch from cfaac83 to cc69271 Compare April 20, 2023 08:33
@Neylix Neylix merged commit 38a3141 into develop Apr 20, 2023
@Neylix Neylix deleted the add_named_supervisor_credo_check branch April 20, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Improve code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All supervisor should be names
3 participants