Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All supervisor should be names #978

Closed
Neylix opened this issue Apr 17, 2023 · 0 comments · Fixed by #982
Closed

All supervisor should be names #978

Neylix opened this issue Apr 17, 2023 · 0 comments · Fixed by #982
Labels
bug Something isn't working quality Improve code quality release Involve release / hot reload mecanism

Comments

@Neylix
Copy link
Member

Neylix commented Apr 17, 2023

Describe the problem you discovered

When we add a new children in a supervisor, we need to use an instruction to restart it in the appup when we create a release and a hot reload.
But there is some supervisor that are not named and it make more complex to create the appup as we need to retrieve the pid of the supervisor.

Describe the solution you'd like

All Supervisor should be named.
We could create a new credo check to ensure this.

@Neylix Neylix added bug Something isn't working quality Improve code quality release Involve release / hot reload mecanism labels Apr 17, 2023
@github-project-automation github-project-automation bot moved this to Todo 🚩 in Dev Board Apr 19, 2023
@samuelmanzanera samuelmanzanera moved this from Todo 🚩 to Review 💬 in Dev Board Apr 19, 2023
@github-project-automation github-project-automation bot moved this from Review 💬 to Done 🍻 in Dev Board Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quality Improve code quality release Involve release / hot reload mecanism
Projects
Status: Done 🍻
Development

Successfully merging a pull request may close this issue.

1 participant