Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate previous chain raise on missed tx #1569

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

Neylix
Copy link
Member

@Neylix Neylix commented Oct 8, 2024

Description

During replication, if a node has to sync previous transactions of a chain, when it downloads them it ensure all transactions are fetched from the paging address to the limit address.
It ensure all transactions using there previous address which should be the address of the previous transaction fetched.

Fixes #1563

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Neylix Neylix added bug Something isn't working replication labels Oct 8, 2024
@Neylix Neylix requested a review from samuelmanzanera October 8, 2024 10:30
@Neylix Neylix force-pushed the raise-previous_chain branch from 8e2dd57 to 02afcce Compare October 8, 2024 10:33
@Neylix Neylix force-pushed the raise-previous_chain branch from 02afcce to 0ad5d25 Compare October 8, 2024 10:39
@samuelmanzanera samuelmanzanera added this to the 1.5.11 milestone Oct 8, 2024
Copy link
Member

@samuelmanzanera samuelmanzanera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelmanzanera
Copy link
Member

I'm wondering if we can even improve the security of this flow, by checking the proof of integrity of the transaction chain in the stream processing.

@Neylix
Copy link
Member Author

Neylix commented Oct 8, 2024

I'm wondering if we can even improve the security of this flow, by checking the proof of integrity of the transaction chain in the stream processing.

As discussed, we are planning to evolve the proof of integrity so that it can be validated without the need of the previous transaction data. Combined with the proof of validation using BLS signatures, all the proofs could be validated in the message request before entering the replication process.

@Neylix Neylix merged commit f3b6ae2 into archethic-foundation:develop Oct 8, 2024
2 checks passed
@Neylix Neylix deleted the raise-previous_chain branch October 8, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working replication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chain replication does not fail on error
3 participants