Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chain replication does not fail on error #1563

Closed
Neylix opened this issue Sep 30, 2024 · 0 comments · Fixed by #1569
Closed

Chain replication does not fail on error #1563

Neylix opened this issue Sep 30, 2024 · 0 comments · Fixed by #1569
Labels
bug Something isn't working replication

Comments

@Neylix
Copy link
Member

Neylix commented Sep 30, 2024

Describe the problem you discovered

When a node replicate a transaction, it also replicate the missing previous transactions of the entire chain.
But as the retrieval of the transaction is done through a Stream, if there is a connection issue the node may not retrieve the previous transaction and continue the process of replication.
In the current state, this lead to an error as the current transaction is replicated under a wrong genesis address and broke the chain.

Describe the solution you'd like

During replication, if we detect that the node needs to replicate previous transaction in the chain, if the stream does not returns the expected transaction, the replication should fail.

Epic

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working replication
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant