Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor replication validation #1559

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Refactor replication validation #1559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
279aec8
Refactor PendingTransactionValidation
Neylix Sep 9, 2024
8b69e36
Use ValidationContext in replication validation
Neylix Apr 19, 2024
c2e8671
Add missing cross stamp error serialization
Neylix Apr 19, 2024
6ccf790
Verify pending validation in transaction validator
Neylix Apr 19, 2024
d630577
Refactor LedgerOperations
Neylix Sep 11, 2024
44faa00
Add LedgerValidation to perform LedgerOperations calculation
Neylix Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions lib/archethic/bootstrap/network_init.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ defmodule Archethic.Bootstrap.NetworkInit do
alias Archethic.Election

alias Archethic.Mining
alias Archethic.Mining.LedgerValidation

alias Archethic.PubSub

Expand All @@ -26,7 +27,6 @@ defmodule Archethic.Bootstrap.NetworkInit do
alias Archethic.TransactionChain.Transaction
alias Archethic.TransactionChain.Transaction.CrossValidationStamp
alias Archethic.TransactionChain.Transaction.ValidationStamp
alias Archethic.TransactionChain.Transaction.ValidationStamp.LedgerOperations
alias Archethic.TransactionChain.Transaction.ValidationStamp.LedgerOperations.UnspentOutput

alias Archethic.TransactionChain.Transaction.ValidationStamp.LedgerOperations.VersionedUnspentOutput
Expand Down Expand Up @@ -187,20 +187,16 @@ defmodule Archethic.Bootstrap.NetworkInit do
timestamp = DateTime.utc_now() |> DateTime.truncate(:millisecond)
fee = Mining.get_transaction_fee(tx, nil, 0.07, timestamp, nil)
movements = Transaction.get_movements(tx)

resolved_addresses = Enum.map(movements, &{&1.to, &1.to}) |> Map.new()

operations =
%LedgerOperations{fee: fee}
|> LedgerOperations.consume_inputs(
address,
timestamp,
unspent_outputs,
Transaction.get_movements(tx),
LedgerOperations.get_utxos_from_transaction(tx, timestamp, 1)
)
|> elem(1)
|> LedgerOperations.build_resolved_movements(movements, resolved_addresses, tx_type)
%LedgerValidation{fee: fee}
|> LedgerValidation.filter_usable_inputs(unspent_outputs, nil)
|> LedgerValidation.mint_token_utxos(tx, timestamp, 1)
|> LedgerValidation.build_resolved_movements(movements, resolved_addresses, tx_type)
|> LedgerValidation.validate_sufficient_funds()
|> LedgerValidation.consume_inputs(address, timestamp)
|> LedgerValidation.to_ledger_operations()

validation_stamp =
%ValidationStamp{
Expand Down
6 changes: 3 additions & 3 deletions lib/archethic/contracts/interpreter/library/common/chain_impl.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ defmodule Archethic.Contracts.Interpreter.Library.Common.ChainImpl do

alias Archethic.Crypto

alias Archethic.Tag
alias Archethic.Mining.LedgerValidation

alias Archethic.TransactionChain.Transaction.ValidationStamp.LedgerOperations
alias Archethic.Tag

alias Archethic.Utils

Expand Down Expand Up @@ -85,7 +85,7 @@ defmodule Archethic.Contracts.Interpreter.Library.Common.ChainImpl do
end

@impl Chain
def get_burn_address(), do: LedgerOperations.burning_address() |> Base.encode16()
def get_burn_address(), do: LedgerValidation.burning_address() |> Base.encode16()

@impl Chain
def get_previous_address(previous_public_key) when is_binary(previous_public_key),
Expand Down
18 changes: 2 additions & 16 deletions lib/archethic/mining/distributed_workflow.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ defmodule Archethic.Mining.DistributedWorkflow do

alias Archethic.Mining.Error
alias Archethic.Mining.MaliciousDetection
alias Archethic.Mining.PendingTransactionValidation
alias Archethic.Mining.TransactionContext
alias Archethic.Mining.ValidationContext
alias Archethic.Mining.WorkflowRegistry
Expand Down Expand Up @@ -403,24 +402,11 @@ defmodule Archethic.Mining.DistributedWorkflow do
:prior_validation,
state,
data = %{
context:
context = %ValidationContext{transaction: tx, validation_time: validation_time},
context: context = %ValidationContext{transaction: tx},
ref_timestamp: ref_timestamp
}
) do
new_context =
case PendingTransactionValidation.validate(tx, validation_time) do
:ok ->
context

{:error, error} ->
Logger.debug("Invalid pending transaction - #{inspect(error)}",
transaction_address: Base.encode16(tx.address),
transaction_type: tx.type
)

ValidationContext.set_mining_error(context, error)
end
new_context = ValidationContext.validate_pending_transaction(context)

new_data = Map.put(data, :context, new_context)

Expand Down
Loading
Loading