Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor PendingTransactionValidation to expose public function that are now called by ValidationContext.
Functions can now be simply unit tested
Avoid code duplication by using ValidationContext during replication validation in TransactionValidator
Also verify PendingTransactionValidation during replication validation
Refactor LedgerOperations to use a more friendly struct and reduce code duplication
Also split LedgerOperations calculation in a new module LedgerValidation and let only the ValidationStamp LedgerOperations for serialization
Fixes #907
Checklist: