Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the ability to support adding nacls #31

Merged
merged 6 commits into from
Mar 28, 2025
Merged

Conversation

gambol99
Copy link
Member

No description provided.

@gambol99 gambol99 requested a review from Copilot March 28, 2025 13:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the support for NACLs by adding new documentation and input parameters for configuring NACL rules.

  • Adds a new module documentation file (modules/nacls/README.md) detailing the NACL inputs and outputs.
  • Provides an example usage file (examples/nacls/README.md) that currently contains output descriptions referencing NAT Gateway properties.
  • Updates the main README.md to include a new input (nacl_rules) for configuring NACL rules.

Reviewed Changes

Copilot reviewed 5 out of 15 changed files in this pull request and generated no comments.

File Description
modules/nacls/README.md New documentation for NACLs, outlining inputs for NACL rules.
examples/nacls/README.md Example file added, though outputs reference NAT Gateway details.
README.md Updated main documentation to support new nacl_rules input configuration.
Files not reviewed (10)
  • examples/nacls/main.tf: Language not supported
  • examples/nacls/outputs.tf: Language not supported
  • examples/nacls/terraform.tf: Language not supported
  • main.tf: Language not supported
  • modules/nacls/locals.tf: Language not supported
  • modules/nacls/main.tf: Language not supported
  • modules/nacls/terraform.tf: Language not supported
  • modules/nacls/variables.tf: Language not supported
  • tests/nacls.tftest.hcl: Language not supported
  • variables.tf: Language not supported
Comments suppressed due to low confidence (1)

examples/nacls/README.md:14

  • The outputs in this example reference NAT Gateway information which is inconsistent with the NACL support added in this PR. Please update these output descriptions to correctly reflect NACL-related attributes.
| <a name="output_nat_public_ips"></a> [nat_public_ips](#output_nat_public_ips) | The public IPs of the NAT Gateways i.e [public_ip, public_ip] |

Copy link

github-actions bot commented Mar 28, 2025

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 👮 Terraform Security Checkov: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: modules/shared
Pusher: @gambol99, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-network/actions/runs/14130366900

Copy link

github-actions bot commented Mar 28, 2025

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 👮 Terraform Security Checkov: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: .
Pusher: @gambol99, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-network/actions/runs/14130366900

Copy link

github-actions bot commented Mar 28, 2025

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 👮 Terraform Security Checkov: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: modules/nacls
Pusher: @gambol99, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-network/actions/runs/14130366900

@gambol99 gambol99 merged commit d8187b6 into main Mar 28, 2025
36 checks passed
@gambol99 gambol99 deleted the feat/nacls branch March 28, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant