Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/changes #30

Merged
merged 7 commits into from
Mar 22, 2025
Merged

feat/changes #30

merged 7 commits into from
Mar 22, 2025

Conversation

gambol99
Copy link
Member

@gambol99 gambol99 commented Mar 22, 2025

  • docs: moving the banner into a different directory
  • feat: added the changes to the shared module to only share the subnets
  • chore: added the removal and updating the readme
  • feat: removed the enable nat and tgw gateway, supplying the values is enough. changing the additional_subnets to subnets
  • chore: added and updated the examples for base and direct, plus added a shared module

Copy link

github-actions bot commented Mar 22, 2025

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 👮 Terraform Security Checkov: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: .
Pusher: @gambol99, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-network/actions/runs/14011002140

Copy link

github-actions bot commented Mar 22, 2025

Pull Request Review Status

  • 🖌 Terraform Format and Style: success
  • 🔍 Terraform Linting: success
  • 👮 Terraform Security Check: success
  • 👮 Terraform Security Checkov: success
  • 🔘 Terraform Tests: success
  • 🔧 Terraform Initialisation: success
  • 🤖 Terraform Validation: success
  • 🤖 Terraform Example Validation: success
  • 📖 Terraform Documentation: success
  • 🔖 Commitlint: success

Working Directory: modules/shared
Pusher: @gambol99, Action: pull_request
Workflow Run Link: https://github.com/appvia/terraform-aws-network/actions/runs/14011002140

@gambol99 gambol99 merged commit becc5d5 into main Mar 22, 2025
24 checks passed
@gambol99 gambol99 deleted the feat/changes branch March 22, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant