Deprecate the request env keys to set the action #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuring the action name with the request env keys `appsignal.action` and `appsignal.route` don't give a reasonable guarantee when the action name is set. The `Appsignal.set_action` helper sets the action name immediately. The method via the request env sets the action name using `set_action_if_nil`. If the action name is set by one of our instrumentations beforehand or another `Appsiganl.set_action` call, there's no guarantee this value is used as the action name. We also never documented either of these keys, so I don't expect a lot of people to be using them. Closes #1116
This is a message from the daily scheduled checks. |
luismiramirez
approved these changes
Jul 8, 2024
jeffkreeftmeijer
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuring the action name with the request env keys
appsignal.actionandappsignal.routedon't give a reasonable guarantee when the action name is set. TheAppsignal.set_actionhelper sets the action name immediately.The method via the request env sets the action name using
set_action_if_nil. If the action name is set by one of our instrumentations beforehand or anotherAppsiganl.set_actioncall, there's no guarantee this value is used as the action name.We also never documented either of these keys, so I don't expect a lot of people to be using them.
Closes #1116