Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate appsignal.route and appsignal.action request keys #1116

Closed
tombruijn opened this issue Jun 26, 2024 · 0 comments · Fixed by #1155
Closed

Deprecate appsignal.route and appsignal.action request keys #1116

tombruijn opened this issue Jun 26, 2024 · 0 comments · Fixed by #1155
Assignees
@tombruijn
Labels
chore

Comments

@tombruijn
Copy link
Member

Let's recommend people use Appsignal.set_action. Especially after the refactor in #329, it will make setting the action name more predictable, as set_action sets the name straight away. The request env keys would set it later.
@tombruijn tombruijn mentioned this issue Jun 26, 2024
Closed
82 tasks
@tombruijn tombruijn self-assigned this Jul 3, 2024
tombruijn added a commit that referenced this issue Jul 4, 2024
@tombruijn
Deprecate the request env keys to set the action
9691d1b 
Configuring the action name with the request env keys `appsignal.action`
and `appsignal.route` don't give a reasonable guarantee when the action
name is set. The `Appsignal.set_action` helper sets the action name
immediately.

The method via the request env sets the action name using
`set_action_if_nil`. If the action name is set by one of our
instrumentations beforehand or another `Appsiganl.set_action` call,
there's no guarantee this value is used as the action name.

We also never documented either of these keys, so I don't expect a lot
of people to be using them.

Closes #1116
@tombruijn tombruijn mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tombruijn tombruijn

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate the request env keys to set the action appsignal/appsignal-ruby
1 participant
@tombruijn