Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OpenTelemetry api to 1.0.0 #828

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Bump OpenTelemetry api to 1.0.0 #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions federation-integration-testsuite-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
},
"homepage": "https://github.com/apollographql/federation#readme",
"dependencies": {
"@opentelemetry/api": "^0.20.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependencies of this package doesn't really matter since it is not published. I think you may want to add it to the dev deps of the top level (also unpublished) package.json so that it's a non peer deps somewhere? But maybe it works if you don't? Perhaps if this works then it's good enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory I guess as long as npm7 is used these dependencies are not needed? api will come in as a peer dependency, the others shouldn't be needed.

"@opentelemetry/tracing": "^0.20.0",
"apollo-graphql": "^0.9.3",
"graphql-tag": "^2.10.4"
}
Expand Down
2 changes: 1 addition & 1 deletion gateway-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"dependencies": {
"@apollo/federation": "file:../federation-js",
"@apollo/query-planner": "file:../query-planner-js",
"@opentelemetry/api": "^0.20.0",
"@types/node-fetch": "2.5.10",
"apollo-graphql": "^0.9.3",
"apollo-reporting-protobuf": "^0.8.0",
Expand All @@ -41,6 +40,7 @@
"pretty-format": "^26.0.0"
},
"peerDependencies": {
"@opentelemetry/api": "^1.0.0",
"graphql": "^14.5.0 || ^15.0.0"
}
}
Loading