Bump OpenTelemetry api to 1.0.0 #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update related OT libraries for testing.
glasser
approved these changes
Jun 21, 2021
| @@ -18,8 +18,6 @@ | |||
| }, | |||
| "homepage": "https://github.com/apollographql/federation#readme", | |||
| "dependencies": { | |||
| "@opentelemetry/api": "^0.20.0", | |||
There was a problem hiding this comment.
The dependencies of this package doesn't really matter since it is not published. I think you may want to add it to the dev deps of the top level (also unpublished) package.json so that it's a non peer deps somewhere? But maybe it works if you don't? Perhaps if this works then it's good enough.
There was a problem hiding this comment.
In theory I guess as long as npm7 is used these dependencies are not needed? api will come in as a peer dependency, the others shouldn't be needed.
BrynCooke
added a commit
that referenced
this pull request
Jun 25, 2021
This PR adds instrumentation to emit the following spans: federation.request - total time to server a request. federation.validate - time to validate the federated query. federation.plan - time to plan the federated query. federation.execute - the total time executing query. federation.fetch - time fetching data from a subgraph. federation.postprocessing - time to render the response from all the subgraph data. The instrumentation looks a little messy due to the requirement to set error status on spans on exception, but also if errors are added to the response. It is a reissue of the following PRs #803 #828
trevor-scheer
pushed a commit
that referenced
this pull request
Jun 29, 2021
This PR adds instrumentation to emit the following spans: federation.request - total time to server a request. federation.validate - time to validate the federated query. federation.plan - time to plan the federated query. federation.execute - the total time executing query. federation.fetch - time fetching data from a subgraph. federation.postprocessing - time to render the response from all the subgraph data. The instrumentation looks a little messy due to the requirement to set error status on spans on exception, but also if errors are added to the response. It is a reissue of the following PRs #803 #828
trevor-scheer
added a commit
that referenced
this pull request
Jun 29, 2021
* Add OpenTelemetry support This PR adds instrumentation to emit the following spans: federation.request - total time to server a request. federation.validate - time to validate the federated query. federation.plan - time to plan the federated query. federation.execute - the total time executing query. federation.fetch - time fetching data from a subgraph. federation.postprocessing - time to render the response from all the subgraph data. The instrumentation looks a little messy due to the requirement to set error status on spans on exception, but also if errors are added to the response. It is a reissue of the following PRs #803 #828 * WIP on opentelemetry docs * First run at OT docs ready for review * Incorporate feedback from @BrynCooke * Add note to update @apollo/gateway * Release - apollo-federation-integration-testsuite@0.25.2 - @apollo/gateway@0.31.0 - @apollo/harmonizer@0.3.4 * Update changelog for publish Co-authored-by: bryncooke <bryncooke@gmail.com> Co-authored-by: Stephen Barlow <barlow.stephen+git@gmail.com> Co-authored-by: Stephen Barlow <stephen@apollographql.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump OpenTelemetry api to 1.0.0
Update related OT libraries for testing.
Note that the api dependenciy has been moved to a peer dependency in gateway-js.
Also dependencies have been remove from here, but perhaps there was a reason they were added in the first place?