Expand support for node@18 #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
💝 Thanks @trevor-scheer! I updated the issue to only include the node18 update, totally agree with waiting on node12 deprecation. Changes look great, once we figure out which version to land this in. |
1 task
Merged
benweatherman
pushed a commit
that referenced
this pull request
Jun 24, 2022
* Expand support for node@18
jeffjakub
added a commit
that referenced
this pull request
Oct 28, 2022
* Expand support for node@18 (#1884) * Expand support for node@18 * Resolving package.json and circleci config.yml conflicts with version-0.x branch. * Correcting package-lock.json files. * Correcting comments. * Updating circleci config for GraphQL v15 Support step. Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com> Co-authored-by: Jeff Jakub <jeffjakub@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1752
We can't drop support for Node 12 without a major version bump.
Aside from it being EOL, I don't see much incentive to drop it in any hurry, either. i.e. we're no longer polyfilling anything (which was an incentive to drop v10).
@benweatherman if you'd like me to leave your issue open anyway, I'll remove the
Fixes #1752and just reference the issue instead.According to the comment in the Orb we use, the "install specific npm version" should no longer be necessary (as of a very long time ago). I removed it since it was causing issues with the node 18 tests and everything seems to be working as expected.
https://github.com/apollographql/CircleCI-Orbs/blob/main/src/oss-ci-cd-tooling/orb.yml#L41-L46
TODO